Implement Proper Disabled SRAM Behavior

pokemon-speedrunning / gambatte-speedrun

Fork of https://github.com/sinamas/gambatte with Pokemon speedrunning-related changes.

GNU General Public License v2.0

94 stars 27 forks source link

Implement Proper Disabled SRAM Behavior #85

Closed CasualPokePlayer closed 3 years ago

CasualPokePlayer commented 3 years ago

Fixes https://github.com/pokemon-speedrunning/gambatte-speedrun/issues/78

(and testrunner passes fine with this unlike last attempt)

Also addresses https://github.com/TASVideos/BizHawk/issues/2482 on the Gambatte side.

EDIT: Keeping as a draft until I handle some more tests on more edge cases.

CasualPokePlayer commented 3 years ago

Apparently with my fuckery with the open_bus branch (now renamed to open_bus_meme with open_bus being BizHawk one) apparently closed this PR (deleted I'm going ???). After some further testing I'll go open another PR for this.