search

pokemongo-dev-contrib / pokemongo-json-pokedex

Transform the data from the Pokemon GO master files to a better readable & processable JSON file.
Apache License 2.0
54 stars 14 forks source link

Pokemon Egg Distance #1

Open Sifogiannos opened 6 years ago

Sifogiannos commented 6 years ago

Could it be easy to add pokemon egg distance?

BrunnerLivio commented 6 years ago

I'm actually unable to find that information in the GAME_MASTER files.

Maybe you have more luck. Search here

Sifogiannos commented 6 years ago

As i can see, in the specific file "GAME_MASTER" there is none data for pokemon egg distance, we should probably import another file that contain that data.

BrunnerLivio commented 6 years ago

I don't like relying on third party services. Any suggestions though?

Furtif commented 6 years ago

Look this

BrunnerLivio commented 6 years ago

Kinda forgot this issue, sorry about that. @Furtif thanks for this snippet. I do not want to debug your code; can you elaborate how you calculate this? Like which data from the GAME_MASTER.json is needed in order to calculate the Egg Distance?

Sifogiannos commented 5 years ago

Long time no see, i dont know if its a good idea but it just an opinion. We could use the data form https://www.serebii.net/pokemongo/pokemon.shtml to extract data for egg hatching and then merge them with the available data from game master.

What do you think?

BrunnerLivio commented 5 years ago

@Sifogiannos Hmm serebii is quite reliable, so I guess could be doable. Do not really have the time to implement it myself though :/