pokemongo-dev-contrib / pokemongo-json-pokedex

Transform the data from the Pokemon GO master files to a better readable & processable JSON file.
Apache License 2.0
54 stars 14 forks source link

Internationalization #17

Closed na-ji closed 5 years ago

na-ji commented 5 years ago

Hello!

Feature Request

Is your feature request related to a problem? Please describe. It would be useful if the output also included the translation of the names. At least for the Pokemon names and the moves names. The translations are not in the Game Master, but there are a few ways to find it.

Describe the solution you'd like I found that translations are saved in the game assets. Two files could be useful: pokemon.txt and moves.txt. And they are quite easy to parse.

Describe alternatives you've considered An alternative source for the names could be node APIs like oakdex-pokedex.

Teachability, Documentation, Adoption, Migration Strategy A class named Translation with a property for each locale. Each property could be the locale ISO code. Documentation:


Translation

Then the Pokemon class could have a property names of type Translation. To not break the existing model, Pokemon could keep the name property. Same thing for the Move class.

Thank you!

BrunnerLivio commented 5 years ago

Great issue! Thanks for digging out the needed information. So the new model for pokemon would be something like:


{
  "name": "Bulbasaur",
  "names": {
    "en": "Bulbasaur",
    "de": "Bisasam",
    "fr": "Bulbizarre"
    ...
  }
  ...
}

I would be fine with that. Should be possible, I'll have a look into it!

na-ji commented 5 years ago

Thanks @BrunnerLivio!

BrunnerLivio commented 5 years ago

@na-ji Changed the structure of the translation. See #22

na-ji commented 5 years ago

I like this structure!

BrunnerLivio commented 5 years ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: