Closed na-ji closed 5 years ago
Great issue! Thanks for digging out the needed information. So the new model for pokemon would be something like:
{
"name": "Bulbasaur",
"names": {
"en": "Bulbasaur",
"de": "Bisasam",
"fr": "Bulbizarre"
...
}
...
}
I would be fine with that. Should be possible, I'll have a look into it!
Thanks @BrunnerLivio!
@na-ji Changed the structure of the translation. See #22
I like this structure!
:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Hello!
Feature Request
Is your feature request related to a problem? Please describe. It would be useful if the output also included the translation of the names. At least for the Pokemon names and the moves names. The translations are not in the Game Master, but there are a few ways to find it.
Describe the solution you'd like I found that translations are saved in the game assets. Two files could be useful: pokemon.txt and moves.txt. And they are quite easy to parse.
Describe alternatives you've considered An alternative source for the names could be node APIs like oakdex-pokedex.
Teachability, Documentation, Adoption, Migration Strategy A class named
Translation
with a property for each locale. Each property could be the locale ISO code. Documentation:Translation
pt string Translation in Portuguese
Then the
Pokemon
class could have a propertynames
of typeTranslation
. To not break the existing model,Pokemon
could keep thename
property. Same thing for theMove
class.Thank you!