luissmg
commented
5 years ago Just realized the same happens with the rarity field.
Closed luissmg closed 5 years ago
luissmg
commented
5 years ago Just realized the same happens with the rarity field.
BrunnerLivio
commented
5 years ago I actually do not have a clue why it is sometimes present, and sometimes not. I've created a small script which checks which Pokemon do not have any buddySize. The output does not really show a pattern for me:
== 176 Pokemon WITHOUT buddySize==
Bulbasaur
Charmander
Charmeleon
Squirtle
Wartortle
Metapod
Kakuna
Rattata
Rattata Alola
Raticate
Raticate Alola
Ekans
Raichu
Raichu Alola
Sandshrew
Sandshrew Alola
Sandslash
Sandslash Alola
Nidoran
Nidorina
Nidoran
Nidorino
Clefairy
Vulpix
Vulpix Alola
Jigglypuff
Oddish
Gloom
Paras
Parasect
Venonat
Diglett
Diglett Alola
Meowth
Meowth Alola
Persian
Persian Alola
Psyduck
Mankey
Growlithe
Poliwag
Abra
Machop
Bellsprout
Tentacool
Geodude
Geodude Alola
Ponyta
Slowpoke
Farfetch'd
Doduo
Seel
Dewgong
Shellder
Krabby
Voltorb
Exeggcute
Cubone
Marowak
Marowak Alola
Lickitung
Tangela
Horsea
Goldeen
Mr. Mime
Magikarp
Ditto
Vaporeon
Jolteon
Flareon
Omanyte
Kabuto
Dratini
Mew
Chikorita
Bayleef
Cyndaquil
Quilava
Totodile
Croconaw
Sentret
Furret
Hoothoot
Spinarak
Ariados
Chinchou
Igglybuff
Togetic
Mareep
Flaaffy
Bellossom
Marill
Azumarill
Sudowoodo
Politoed
Aipom
Sunflora
Yanma
Wooper
Espeon
Umbreon
Unown
Pineco
Dunsparce
Gligar
Snubbull
Qwilfish
Shuckle
Sneasel
Teddiursa
Slugma
Magcargo
Swinub
Corsola
Remoraid
Octillery
Delibird
Houndour
Houndoom
Phanpy
Porygon2
Tyrogue
Hitmontop
Larvitar
Pupitar
Celebi
Treecko
Grovyle
Torchic
Mudkip
Marshtomp
Poochyena
Mightyena
Zigzagoon
Linoone
Silcoon
Cascoon
Seedot
Taillow
Ralts
Kirlia
Surskit
Shroomish
Nincada
Whismur
Azurill
Skitty
Sableye
Mawile
Aron
Meditite
Roselia
Gulpin
Numel
Torkoal
Spoink
Trapinch
Seviper
Barboach
Corphish
Baltoy
Feebas
Castform
Castform Rainy
Castform Snowy
Castform Sunny
Kecleon
Shuppet
Chimecho
Absol
Snorunt
Clamperl
Luvdisc
Bagon
Beldum
Jirachi
Maybe this field is deprecated?
Just investigated a little bit. rarityseems to be only present when the Pokemon is of the type Legendary or Mythic.
I became the output with my script:
== 24 Pokemon WITH rarity
Articuno:Legendary
Zapdos:Legendary
Moltres:Legendary
Mewtwo:Legendary
Mew:Mythic
Raikou:Legendary
Entei:Legendary
Suicune:Legendary
Lugia:Legendary
Ho Oh:Legendary
Celebi:Mythic
Regirock:Legendary
Regice:Legendary
Registeel:Legendary
Latias:Legendary
Latios:Legendary
Kyogre:Legendary
Groudon:Legendary
Rayquaza:Legendary
Jirachi:Mythic
Deoxys:Mythic
Deoxys Attack:Mythic
Deoxys Defense:Mythic
Deoxys Speed:Mythic
I could add a third rarity like "Normal", if not rarity field is present inside the GAME_MASTER.json file
luissmg
commented
5 years ago Thanks for the clarification! It's not necessary to add the Normal rarity, one can predict that on the code.
The size is what triggers me the most haha Will try to check. Maybe all those pokémon are small or medium... I don't know
BrunnerLivio
commented
5 years ago @luissmg Unfortunately I do not have time to investigate more onto this. If you find something out, I'm more than happy to know. I'll leave this issue open, in case someone knows more.
luissmg
commented
5 years ago @BrunnerLivio I will take a look into the list you provided and verify their rarity :)
luissmg
commented
5 years ago @BrunnerLivio, got some news. About the buddySize, the ones that have no buddy size, as far as I can tell and searched, correspond to Medium!
As far as Rarityconcerns... I couldn't find anything to extract data. But I found one site that mentions different rarity for every pokémon. Don't know how they get that info.
BrunnerLivio
commented
5 years ago @luissmg Thank you for the update.
About the buddySize, the ones that have no buddy size, as far as I can tell and searched, correspond to Medium!
From where did you get that information?
luissmg
commented
5 years ago @BrunnerLivio I checked this website and tested for some cases of the list and they were all Medium.
luissmg
commented
5 years ago @BrunnerLivio What do you want to do here? And can I help?
BrunnerLivio
commented
5 years ago @luissmg I want add to each pokemon, which does not have any buddy size, the type medium. Should be rather easy to add this, but I am quite busy at the moment. You can add it yourself if you need it urgently, or I’ll do it next week (or maybe even this week).
luissmg
commented
5 years ago @BrunnerLivio I don't need it urgently but I would like to contribute to this repo since I am using it and it is really good and you are such a nice guy 😸
BrunnerLivio
commented
5 years ago @luissmg Always open for pull requests :) The best way to start is probably the fille pokemongo-json-pokedex/src/processing/pokemon/components/buddySize.ts. I think this should be possible in one line of code :P Good luck!
Would be nice if you add 1-2 additional test cases to your implementation.
luissmg
commented
5 years ago Ye, this one should be a trivial one line code fix haha Anyway, will make a PR today more at the end of the day with the changes and with test cases!
BrunnerLivio
commented
5 years ago :tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
I was looking into the json and the field with the buddy size is not always defined. Can you explain why or which are the cases where it does not get defined?