pokemongo-dev-contrib / pokemongo-json-pokedex

Transform the data from the Pokemon GO master files to a better readable & processable JSON file.
Apache License 2.0
54 stars 14 forks source link

Fix pokemon having only one cinematicMove #28

Closed imiguelacuna closed 5 years ago

imiguelacuna commented 5 years ago

Fixes issue #27

feralheart commented 5 years ago

When will this PR merged?

BrunnerLivio commented 5 years ago

@feralheart The problem with this PR is, it reverts #6:

JSON of this PR (cinemativMoves and quickMoves are duplicates again) :


{
   "dex": 151,
   "name": "Mew",
   ...
   "cinematicMoves": [
      {
         "name": "Psychic",
         "id": "PSYCHIC"
      },
      {
         "name": "Ancient Power",
         "id": "ANCIENT_POWER"
      },
      {
         "name": "Dragon Claw",
         "id": "DRAGON_CLAW"
      },
      {
         "name": "Psyshock",
         "id": "PSYSHOCK"
      },
      {
         "name": "Ice Beam",
         "id": "ICE_BEAM"
      },
      {
         "name": "Blizzard",
         "id": "BLIZZARD"
      },
      {
         "name": "Hyper Beam",
         "id": "HYPER_BEAM"
      },
      {
         "name": "Solar Beam",
         "id": "SOLAR_BEAM"
      },
      {
         "name": "Thunderbolt",
         "id": "THUNDERBOLT"
      },
      {
         "name": "Thunder",
         "id": "THUNDER"
      },
      {
         "name": "Psychic",
         "id": "PSYCHIC"
      },
      {
         "name": "Ancient Power",
         "id": "ANCIENT_POWER"
      },
      {
         "name": "Dragon Claw",
         "id": "DRAGON_CLAW"
      },
      {
         "name": "Psyshock",
         "id": "PSYSHOCK"
      },
      {
         "name": "Ice Beam",
         "id": "ICE_BEAM"
      },
      {
         "name": "Blizzard",
         "id": "BLIZZARD"
      },
      {
         "name": "Hyper Beam",
         "id": "HYPER_BEAM"
      },
      {
         "name": "Solar Beam",
         "id": "SOLAR_BEAM"
      },
      {
         "name": "Thunderbolt",
         "id": "THUNDERBOLT"
      },
      {
         "name": "Thunder",
         "id": "THUNDER"
      },
      {
         "name": "Flame Charge",
         "id": "FLAME_CHARGE"
      },
      {
         "name": "Low Sweep",
         "id": "LOW_SWEEP"
      },
      {
         "name": "Overheat",
         "id": "OVERHEAT"
      },
      {
         "name": "Focus Blast",
         "id": "FOCUS_BLAST"
      },
      {
         "name": "Energy Ball",
         "id": "ENERGY_BALL"
      },
      {
         "name": "Stone Edge",
         "id": "STONE_EDGE"
      },
      {
         "name": "Gyro Ball",
         "id": "GYRO_BALL"
      },
      {
         "name": "Bulldoze",
         "id": "BULLDOZE"
      },
      {
         "name": "Rock Slide",
         "id": "ROCK_SLIDE"
      },
      {
         "name": "Grass Knot",
         "id": "GRASS_KNOT"
      },
      {
         "name": "Flash Cannon",
         "id": "FLASH_CANNON"
      },
      {
         "name": "Wild Charge",
         "id": "WILD_CHARGE"
      },
      {
         "name": "Dark Pulse",
         "id": "DARK_PULSE"
      },
      {
         "name": "Dazzling Gleam",
         "id": "DAZZLING_GLEAM"
      },
      {
         "name": "Surf",
         "id": "SURF"
      }
   ],
   "quickMoves": [
      {
         "name": "Pound Fast",
         "id": "POUND_FAST"
      },
      {
         "name": "Steel Wing Fast",
         "id": "STEEL_WING_FAST"
      },
      {
         "name": "Charge Beam Fast",
         "id": "CHARGE_BEAM_FAST"
      },
      {
         "name": "Shadow Claw Fast",
         "id": "SHADOW_CLAW_FAST"
      },
      {
         "name": "Volt Switch Fast",
         "id": "VOLT_SWITCH_FAST"
      },
      {
         "name": "Struggle Bug Fast",
         "id": "STRUGGLE_BUG_FAST"
      },
      {
         "name": "Frost Breath Fast",
         "id": "FROST_BREATH_FAST"
      },
      {
         "name": "Dragon Tail Fast",
         "id": "DRAGON_TAIL_FAST"
      },
      {
         "name": "Infestation Fast",
         "id": "INFESTATION_FAST"
      },
      {
         "name": "Poison Jab Fast",
         "id": "POISON_JAB_FAST"
      },
      {
         "name": "Rock Smash Fast",
         "id": "ROCK_SMASH_FAST"
      },
      {
         "name": "Snarl Fast",
         "id": "SNARL_FAST"
      },
      {
         "name": "Cut Fast",
         "id": "CUT_FAST"
      },
      {
         "name": "Waterfall Fast",
         "id": "WATERFALL_FAST"
      }
   ],
   ...
   "id": "MEW"
}

I planned to have a look at myself, but did not find the time yet

feralheart commented 5 years ago

What if we put all cinematic moves what a pokemon can learn in an array and than drop the duplicates?

BrunnerLivio commented 5 years ago

Fixed with #31. Really stupid bug from me. :sweat:

Thanks anyway for your contribution @imiguelacuna, highly appreciated! I am adding you as a contributor in the CHANGELOG.md file for 3.2.1

BrunnerLivio commented 5 years ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: