search

pokemongo-dev-contrib / pokemongo-json-pokedex

Transform the data from the Pokemon GO master files to a better readable & processable JSON file.
Apache License 2.0
54 stars 14 forks source link

Add medium buddy size for pokemon without it in game master #34

Closed luissmg closed 5 years ago

luissmg commented 5 years ago

Fixes #25

BrunnerLivio commented 5 years ago

Thanks a lot for the contribution! Great job!

luissmg commented 5 years ago

Thanks. Glad I could help with something!

luissmg commented 5 years ago

@BrunnerLivio I forgot to add the tests. Will add them ASAP!

BrunnerLivio commented 5 years ago

@luissmg That would be nice :). The test cases can be really stupid like e.g. Pokemon with id CHARMANDER should have buddy size medium. You can put these tests into the file test/pokemon.output.ts. You can append it to the object at line 80.

luissmg commented 5 years ago

Sure. Will add them today and merge them

luissmg commented 5 years ago

@BrunnerLivio When will this be in a new release of the lib? And when will you update to the new game master?

BrunnerLivio commented 5 years ago

Will try to release it with the new game master on sunday or monday. Quite busy at the moment :)

luissmg commented 5 years ago

No problem. Just wanted to know when you intended to do it :)

BrunnerLivio commented 5 years ago

Published

luissmg commented 5 years ago

@BrunnerLivio Thank you!!! PS: Do you know if the game master changed today with the last update of the app?

BrunnerLivio commented 5 years ago

@luissmg No, do not know yet, but I think my friends would publish soon a new version, if something had changed.

BrunnerLivio commented 5 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: