search

pokemongo-dev-contrib / pokemongo-json-pokedex

Transform the data from the Pokemon GO master files to a better readable & processable JSON file.
Apache License 2.0
54 stars 14 forks source link

Latest GAME_MASTER #49

Closed Sifogiannos closed 5 years ago

Sifogiannos commented 5 years ago

Is there any way to insert a custom game master (I found the latest), to generate the new files in the outputs?

BrunnerLivio commented 5 years ago

Technically yes. But I want to depend on the pokemongo-game-master repository. Is the requested game master file not available there yet? If so, please create an issue on there.

celandro commented 5 years ago

I just merged. Btw feel free to merge after approval, I am very busy with a new baby

BrunnerLivio commented 5 years ago

@celandro Oh yes sure! Congratulations !! :D

Sifogiannos commented 5 years ago

First of all @celandro congratulations !!! @BrunnerLivio I saw that the repository you mentioned is updated, now is any command to rerun the "collector" to update the files in output folder. It might sounds silly but i did not found a command for this, sorry for questioning all the time. I just run the following npm install and npm start but the pokemon file in output contains undefined. I also had run npm run prepublish but it seems that typescript does not like something in evolutionItem

image

BrunnerLivio commented 5 years ago

"collector" to update the files in output folder.

npm run install - Install dependencies

npm run update - Will fetch all resources and writes the needed TypeScript interfaces (will get executed on postinstall)

npm run start - Runs the main application, which normalizes the fetched resources to the desired output

npm run test - Check whether the output is still valid and expected

I should document this properly.. Anyway - Yes there was an exception. Fixed it all with https://github.com/pokemongo-dev-contrib/pokemongo-json-pokedex/commit/1f7b6b84d2884c3d50f1bede7c8b54ed7180aa49

The problem was that the GAME_MASTER.json suddenly had numeric Ids in itemTemplates[x].pokemonSettings.evolutionBranch.evolutionItemRequirement whereas before only strings were expected.

You can see the changed functionality here

https://github.com/pokemongo-dev-contrib/pokemongo-json-pokedex/commit/1f7b6b84d2884c3d50f1bede7c8b54ed7180aa49#diff-3f48b34b611155998a13820c2afaf976R14

I released pokemongo-json-pokedex@3.4.3 on NPM

Cheers

Livio