search

pokemongo-dev-contrib / pokemongo-json-pokedex

Transform the data from the Pokemon GO master files to a better readable & processable JSON file.
Apache License 2.0
54 stars 14 forks source link

Include Legacy Moves #5

Closed Drexlin closed 5 years ago

Drexlin commented 6 years ago

In your deprecated repo, there was an open issue for including legacy moves. Do you have plans to include them in this repo?

Also, to add another wrinkle... In every GAME_MASTER file I've seen, I've never seen the special Community Day moves listed. Is there any way to get them, other than adding them manually to my database?

BrunnerLivio commented 6 years ago

In your deprecated repo, there was an open issue for including legacy moves. Do you have plans to include them in this repo?

How do I get this information? Are they in older GAME_MASTER files? Can I use the pokemongo-game-master repo to gather this information? Are legacy moves still associated with the current Pokemons?

. In every GAME_MASTER file I've seen, I've never seen the special Community Day moves listed. Is there any way to get them, other than adding them manually to my database?

I do not want to include data from not reliable sources. Is there a reliable source to receive this data?

celandro commented 6 years ago

I manually update my copies. Its a pain for sure. There is no automated way to do this.

If we wanted to make 'small' jsons that only had the pokemon from community day and its moves from that day, I think that would be useful

On Fri, Jul 13, 2018 at 11:49 AM, Livio Brunner notifications@github.com wrote:

In your deprecated repo, there was an open issue for including legacy moves. Do you have plans to include them in this repo?

How do I get this information? Are they in older GAME_MASTER files? Can I use the pokemongo-game-master repo to gather this information? Are legacy moves still associated with the current Pokemons?

. In every GAME_MASTER file I've seen, I've never seen the special Community Day moves listed. Is there any way to get them, other than adding them manually to my database?

I do not want to include data from not reliable data. Is there a reliable source to receive this data?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pokemongo-dev-contrib/pokemongo-json-pokedex/issues/5#issuecomment-404920974, or mute the thread https://github.com/notifications/unsubscribe-auth/AAX4gF0D4VT1q8OpFvl2EZUi3z-70_zNks5uGOuwgaJpZM4VPOB3 .

Drexlin commented 6 years ago

In your deprecated repo, there was an open issue for including legacy moves. Do you have plans to include them in this repo?

How do I get this information? Are they in older GAME_MASTER files? Can I use the pokemongo-game-master repo to gather this information? Are legacy moves still associated with the current Pokemons?

You would have to process all GAME_MASTER files from the beginning of time. But you would only need to do this once. Then, on subsequent releases of the GAME_MASTER file, you could update pokemon.json if it's changed. What I do for my database is for each pokemon, I first mark all moves as 'legacy'. Then I read the new GAME_MASTER file and mark all moves in that file as 'current'.

. In every GAME_MASTER file I've seen, I've never seen the special Community Day moves listed. Is there any way to get them, other than adding them manually to my database?

I do not want to include data from not reliable sources. Is there a reliable source to receive this data?

Well, the moves themselves are already part of the GAME_MASTER file, but the link to the pokemon that has that move is not. @celandro says there is no automated way to do this. It would be cool if this repo could track these things so that people who rely on this repo don't have to do it individually. I would be willing to help in any way I can.

Thanks.

BrunnerLivio commented 6 years ago

You would have to process all GAME_MASTER files from the beginning of time

@Drexlin Seems to be doable. Can you send me which versions are affected of this, so I can take this over?

I manually update my copies. Its a pain for sure. There is no automated way to do this. If we wanted to make 'small' jsons that only had the pokemon from community day and its moves from that day, I think that would be useful

@celandro

Seems to be a use case for a new repository. How do you copy this by yourself? If we maintain this in a repository we could include it into this repository.

celandro commented 6 years ago

I have an abridged history that could be transformed into what is used here. I don't think a different repo is warranted, I think just a special event directory is sufficient.

On Fri, Jul 13, 2018, 2:18 PM Livio Brunner notifications@github.com wrote:

You would have to process all GAME_MASTER files from the beginning of time

@Drexlin https://github.com/Drexlin Seems to be doable. Can you send me which versions are affected of this, so I can take this over?

I manually update my copies. Its a pain for sure. There is no automated way to do this. If we wanted to make 'small' jsons that only had the pokemon from community day and its moves from that day, I think that would be useful

@celandro https://github.com/celandro

Seems to be a use case for a new repository. How do you copy this by yourself? If we maintain this in a repository we could include it into this repository.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/pokemongo-dev-contrib/pokemongo-json-pokedex/issues/5#issuecomment-404956717, or mute the thread https://github.com/notifications/unsubscribe-auth/AAX4gDU3EnNCSEiRtoenHQOzMKYBTziEks5uGQ6mgaJpZM4VPOB3 .

Drexlin commented 6 years ago

So just to recap, trying to make sure I understand where we are and if anything is needed from me...

@celandro can provide an updated pokemon.json (in the format that is used for this repo) that will contain legacy moves, which can be used as a starting point for future GAME_MASTER file processing. If you don't have time to do this, I can certainly try, if you can provide me your "abridged history".

As for the Community Day moves, the suggestion is to create another .json file that will contain these moves. While I would prefer it to be all in one file, I'm not entirely against this as long as it's tracked somewhere. Updates to this file would need to be done manually.

BrunnerLivio commented 6 years ago

@celandro

I think just a special event directory is sufficient.

Where should this directory belong to? pokemongo-game-master?

@Drexlin yep thats how I understood it too.

celandro commented 6 years ago

Make a new directory in pokemongo gamemaster. 1 heavily abridged file for each community day with a date. Same format as the current json, just a few entries for the Pokemon and moves that was available that day. What this repo does with it is up to this repo.

I have most of the files ready to go just unlabeled. I can make a branch with them.

On Wed, Jul 18, 2018, 10:39 AM Livio Brunner notifications@github.com wrote:

@celandro https://github.com/celandro

I think just a special event directory is sufficient.

Where should this directory belong to? pokemongo-game-master?

@Drexlin https://github.com/Drexlin yep thats how I understood it too.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/pokemongo-dev-contrib/pokemongo-json-pokedex/issues/5#issuecomment-406014710, or mute the thread https://github.com/notifications/unsubscribe-auth/AAX4gDX6vQuGd954FPr9s5k-7iQwyl4rks5uH3LOgaJpZM4VPOB3 .

feralheart commented 5 years ago

I made a function in a controller what gives back the array of Legacy Moves. And when I parse the pokemon.json with my app, it also adds the Legaxy Moves

BrunnerLivio commented 5 years ago

Can you share this implementation @feralheart ?

BrunnerLivio commented 5 years ago

3.4.6 introduced legacy moves. Thanks @broglep!