pokemontrades / flairhq

A small project to allow easy adding of flair applications for subreddits (focusing initially on /r/pokemontrades) and easy moderation for moderators.
Apache License 2.0
11 stars 9 forks source link

Add the ability to tell users which trades are not approved for flair and a brief reason why #615

Open pkmnbumba opened 6 years ago

pkmnbumba commented 6 years ago

Two parts to this:

Mod side

User side

After discussion, we will not show which trades are approved, only the ones that aren't approved.

This will allow us to create an automated message for denying flair apps

pkmnbumba commented 6 years ago

Right now, a reference not being approved means either a mod hasn't looked at it yet or the reference didn't count for flair for some reason https://github.com/pokemontrades/flairhq/blob/d2b5ae4b9f96fa6ea82db3562e4822a9e3b34674/api/models/Reference.js#L41

That said, 'false' for approved isn't exactly clear. There are two main ways that I see that we can deal with this:

1) Use a new boolean just for disapprovals 2) We can use the approved: false and have it default to 'Mod hasn't seen this yet', but we probably don't want people seeing that by default.