search

pokemontrades / flairhq

A small project to allow easy adding of flair applications for subreddits (focusing initially on /r/pokemontrades) and easy moderation for moderators.
Apache License 2.0
11 stars 9 forks source link

Fix banlist bug #631

Closed robdy closed 6 years ago

robdy commented 6 years ago

Fixes #589 by replacing \_ with _ and then reverting. The actual issue is that while doing split(/\s*\|\s*/) backslash in username causes splitting.

Kind of workaround here but I haven't found any better solution.

robdy commented 6 years ago

Actually I found out that previous version works but only if you enter FC (which was what I did during the test) so I had to rebuild it a little bit.

Regarding unusual entries - if we want to support them I'd have to write regex to remove all the escaping and then add it back (or rewrite user_regex). Both can be challenging a bit and I'm not sure if it's worth to put such effort here.

robdy commented 6 years ago

Ok I got rid of fromCharCodeas agreed on chat.