search

pokemontrades / flairhq

A small project to allow easy adding of flair applications for subreddits (focusing initially on /r/pokemontrades) and easy moderation for moderators.
Apache License 2.0
11 stars 9 forks source link

Banlist hover #640

Closed robdy closed 4 years ago

robdy commented 6 years ago

Fixes #582. Changed 'Retrading allowed' to inline radio and added new field: image

Result: image

Kirzi commented 6 years ago

I think ideally, the "hover note" box is hidden unless "some" is selected, since it turns out that it's not really needed much. But I'm fine with this as is. Thanks for working on it.

robdy commented 6 years ago

I initially left it visible as there was one entry with Yes (hover) but perhaps you're right that it won't probably be used. Will fix it a bit later.

Edit; would be good to add some basic checking so that Some always go with hover (note to myself).

robdy commented 6 years ago

Ok, all done (hiding + check if empty).

Kirzi commented 6 years ago

Looks good to me, thanks. (tested to check the look/behavior but didn't test an actual ban)

Raia commented 5 years ago

Will try to review this sometime soon :v:

AlMcKinlay commented 4 years ago

Soon never came. Closing as this will also be superceded.