Support emojis in flair text

[pkmnbumba]

646

• [x] Sets default flair if currently no flair / keeps current flair level
• [x] Changes flair_text

Noting that we opted to keep the css_class for old reddit support. Doing this allowed us to keep everything the same for applying for flair.

[SnowPhoenix]

Noting that we opted to keep the css_class for old reddit support. Doing this allowed us to keep everything the same for applying for flair.

I think people wanted to keep it for other reasons as well, but just to make a quick note in case there were any misunderstandings, a CSS class is not necessary for old Reddit support. Old Reddit will include emoji, and they can be manipulated via CSS there, but only if a CSS class is not present. (My original implementation was going to remove CSS classes, but it does make things noticeably more complicated as a function for decoding the emoji codes is also needed in that case.)

Edit: Also I just noticed this code doesn't support emoji for /r/SVExchange?

[Raia]

I pushed some commits to fix some bugs:

• We were still requiring IGN+game, but game should no longer be a requirement to save space
• For helper flair, the regular flair was getting erased when resetting flair text
• Added support for upgrade flair

Outstanding bugs:

• [ ] The flair text preview window doesn't show previews for SVEx flair
• [ ] If someone's flair has just been updated and the user refreshes the page, the preview window doesn't properly show the new flair, but the sprite in the top right is updated. This can lead to a minor issue where if a user tries to set new flair text while their preview is showing an emoji with less characters than their current one, the client-side validation/preview won't be accurate. They still get the "Flairs too long" message from the server upon trying to submit though, which is good.

I don't consider either of the above to be blockers for deploying just so that we can reopen the sub, but we should get them fixed eventually. I think we should split the SVEx stuff into a separate PR so we can get this going for now.

[Raia]

Going to separate out some of the things from here and open a new PR.