search

pokemontrades / flairhq

A small project to allow easy adding of flair applications for subreddits (focusing initially on /r/pokemontrades) and easy moderation for moderators.
Apache License 2.0
11 stars 9 forks source link

Adding references: Default thread permalink does not work #664

Open RSalgadoAtala opened 4 years ago

RSalgadoAtala commented 4 years ago

The default permalink for threads when copying from the Share option does not work when adding a reference, and FlairHQ shows the error message "Looks like you didn't input a proper permalink." For example, the following link gives the error: https://www.reddit.com/r/pokemontrades/comments/hvix00/lf_ha_carbink_ft_most_other_ha_pokémon. I could only solve it by repeating the part after "comments" at the end, like this: https://www.reddit.com/r/pokemontrades/comments/hvix00/lf_ha_carbink_ft_most_other_ha_pokémon/hvix00, which is not exactly intuitive.

SnowPhoenix commented 4 years ago

Hi, thanks for bringing this up! Rejecting the first link is what FlairHQ is supposed to do, but I'll see if we can do something about that error message since it is misleading.

To explain further, links entered in the Trades section should never be a permalink for the thread itself, but the permalink for the comment thread that led to a trade. For example, in this case, the link should be:

https://www.reddit.com/r/pokemontrades/comments/hvix00/lf_ha_carbink_ft_most_other_ha_pokémon/fytobpr?utm_source=share&utm_medium=web2x

The reason for this would be more apparent in a thread where multiple trades were conducted: There needs to be a way of distinguishing between different trades within the same thread.

This applies only to Trade threads, of course. Giveaways are handled differently, and the code correctly accepts thread links for those.

Dengar66 commented 3 years ago

@SnowPhoenix are you thinking to just add verbiage to the error message along the lines of "Please ensure you are using the permalink from your comment thread as opposed to the post." ?