pokemontrades / flairhq

A small project to allow easy adding of flair applications for subreddits (focusing initially on /r/pokemontrades) and easy moderation for moderators.
Apache License 2.0
11 stars 9 forks source link

Send message on denied #90

Open TheSonAlsoRises opened 9 years ago

TheSonAlsoRises commented 9 years ago

Users are currently sent a message when their application is accepted or rejected.

The same should be possible with FAPP:

Raia commented 9 years ago

Flair denied~ (no don't actually do that) We just need link karma for the flairapps account.

AlMcKinlay commented 9 years ago

I need /u/sendmeyourflairapps to have link karma :-P

AlMcKinlay commented 9 years ago

The more I think about this, the more I dislike it. I don't really want to hard code the credentials into fapp...

Why do we not just do it with the current mod's information? That would be much nicer :-(

TheSonAlsoRises commented 9 years ago

Would that be possible to message the user from the logged in account? If it is easier to code and more secure, why not. The only issue I have is that the flair account was anonymous, shielding the mod from potential problems from users whose apps were rejected. But I assume we could log in as /u/sendmeyourflairapps in that case?

AlMcKinlay commented 9 years ago

Yeah, it's possible.

I know Raia doesn't like it because it fills up her inbox/output, but meh :-P

The other problem would be I requesting another permission for reddit from all users. So, maybe not the best idea (a few already aren't happy with the existing permissons).

Raia commented 9 years ago

If I am the only one with an issue, I can just manually log into the account and send the message myself, not a big deal. I did like the anonymity too.

Can always just have a link to a pre-filled PM form (like the flair bots do) and we can hit send ourselves.

AlMcKinlay commented 9 years ago

I think it would be nice for it to be handled in the application seamlessly.

I can implement it with /u/sendmeyourflairapps I would just prefer to use the current logged in user.

AlMcKinlay commented 9 years ago

So, we have another option which is sending it as /r/pokemontrades

Although, we just realised that will send it as modmail, which obviously means it'll show up for everyone which isn't great.

TheSonAlsoRises commented 9 years ago

Take the easy way out and use the current user's credentials to send messages. We will login as /u/sendmeyourflairapps if we need to send an anonymous message while processing apps.

Raia commented 9 years ago

@TheSonAlsoRises, I suggested on IRC earlier that we make a new non-mod account to send the PMs from. That way we don't have as much of a security risk, we still get the anonymity, and we can still be on the same page if someone asks about their flair app.

AlMcKinlay commented 9 years ago

Pulling this up the queue.

We are going to put sendmeyourflairapp's oauth key into the app (well, not hardcoded, it'll be a config thing) in #248 so we may as well implement this.

I will make it use sendmeyourflairapp and if we need to do a captcha (will be unlikely) I will show it to the mod who is clicking the button. Agreed?

Raia commented 9 years ago

I will make it use sendmeyourflairapp and if we need to do a captcha (will be unlikely) I will show it to the mod who is clicking the button. Agreed?

Sounds good. Try contacting Deimorz to see if he can give us a captcha bypass on that account, he is usually around on snoonet IRC.

AlMcKinlay commented 8 years ago

I think this has been fixed by @not-an-aardvark 's changes, yes?

not-an-aardvark commented 8 years ago

/u/FlairHQ hasn't needed any captchas for some reason. It has picked up a bit of karma, so maybe that's why.

AlMcKinlay commented 8 years ago

The issue was for sending mails on approval and denial of applications. I believe you did that, yes?

not-an-aardvark commented 8 years ago

It currently sends mail on approval, but not denial.

AlMcKinlay commented 8 years ago

I think we decided that we weren't going to do denials because people can do that manually. Happy for me to close?

not-an-aardvark commented 8 years ago

Fine by me. I was thinking denials could be a future goal once we get the notification center working -- they could get sent with a custom message from /u/FlairHQ, and then any mod would be able to see the response through the notification center.

AlMcKinlay commented 8 years ago

Ok, I've reopened and renamed. We can get to this at some point.