Add quotes command

[AlMcKinlay]

• [x] Fix indentation
• [x] Return message if called with get (or no command) and no id, but there are no messages eg
• [x] Clean up code, it's horrid
• [x] Add id to search results
• [x] Change help text
• [x] Add more than 1 result to search
• [ ] Paginate search results

[AlMcKinlay]

Table info

CREATE TABLE `Quote` (
  `ID` int(11) NOT NULL  AUTO_INCREMENT PRIMARY KEY,
  `Author` text NOT NULL,
  `Message` text NOT NULL,
  `Chan` text NOT NULL
)

[AlMcKinlay]

Any interest in this PR? If not, I'll close it and just keep it on my fork for my version. I just want to tidy up the number of branches I have.

[robdy]

@McInkay, what do you think about returning some message if someone use get but there are no quotes? Like that:

if (result) {
  return `${result.Message} (submitted by ${result.Author})`;
}
else {
  return 'No quotes for this channel';
};

Anyway, looks fine to me. Tested all the commands, no issue found.

[AlMcKinlay]

@robdy Hmm, does that not happen?

return result ? `${result.Message} (submitted by ${result.Author})` : `No results for ${quote}`;

This should do that, shouldn't it? Or am I misunderstanding what you are suggesting?

[AlMcKinlay]

I think I'll refactor this because I'm not happy with how the code is laid out as it's been so long since I implemented it :-P

[robdy]

I mean if you want to get the random one by .quote get when there are no quotes in the database it'll skip if (quote) (as quote is undefined), go to

return db.conn.query('SELECT * FROM Quote WHERE Quote.Chan = ? ORDER BY RAND() LIMIT 1', [channel]).get(0).then(result => {
  return `${result.Message} (submitted by ${result.Author})`

and return error only in the console.

[AlMcKinlay]

Oh duh, I was confused because the "get" was indented incorrectly. Aye, I'll add that.

[AlMcKinlay]

I have refactored this and added the message if there are no quotes and you ask for a random one.

[robdy]

LGTM

[AlMcKinlay]

I've updated but I still need to test it. I think I'll get sqlite in before we merge this one because it makes it much simpler to test. I've got 1 more PR to do (just about to put it up) before I put up sqlite.