poketwo / poketwo

A (not so) small Pokécord clone.
https://poketwo.net
GNU General Public License v3.0
561 stars 264 forks source link

Box Opening Bug #176

Closed yorii260 closed 3 years ago

yorii260 commented 3 years ago

Describe the bug I think most of you know about this bug, but I wanted to report it anyway, a lot of dishonest people are abusing it by opening it, 200, 300 even more than a thousand boxes! so i wanted to know what you guys are going do about it.

Screenshots Screenshot_20210316-191036_Discord.png Screenshot_20210316-191830_Discord.png

I know that there are people who get -2, -3 because of the lag, but there are the funny ones who repeat the command is the bot returns 200 boxs, I hope you can act on this error

I can provide ids and proofs of users using this bug.

tlq44 commented 3 years ago

Agreed. It is absurdly easy for anyone to use their alt account to open several hundreds of master boxes and then ditching that account, providing a heavy imbalance and unfairness to those who do not exploit this.

HeyHeyHEyasdfgsaddfc commented 3 years ago

How do i do it?

JKF-404 commented 3 years ago

I suggest the developers to wipe out the exploiter's account or punish them for their doing. Adding a "security method" such as preventing newbie accounts to use the bot might help.

Ezio208 commented 3 years ago

Try sending less DM messages on discord by the bot. Also the battle method by DM can be removed and maybe add something like you use a move on the server itself

DarshSrivastav commented 3 years ago

just wanted to ask that today after the bot came online again at that time I had 1k pc while before the bot went offline I had 23k and also my few legs are not there in my pokemon list which were there before the bot went online pls help I am very sad and scared on this issue cause my legs are also gone

yorii260 commented 3 years ago

just wanted to ask that today after the bot came online again at that time I had 1k pc while before the bot went offline I had 23k and also my few legs are not there in my pokemon list which were there before the bot went online pls help I am very sad and scared on this issue cause my legs are also gone

read #status in poketwo server.

ghost commented 3 years ago

just wanted to ask that today after the bot came online again at that time I had 1k pc while before the bot went offline I had 23k and also my few legs are not there in my pokemon list which were there before the bot went online pls help I am very sad and scared on this issue cause my legs are also gone

read #status in poketwo server.

:point_up:

Kuraven commented 3 years ago

for all the people absolutely losing it because of this glitch; 1) it takes almost a month to get an account with enough votes on it for a master box 2) Boxes aren't tradeable, and most people don't have the dedication to actually wait a month to be able to do this 3) When you get negative boxes, it takes time for u to get back in the positives, so u're really only just opening them and paying the price sooner. 4) I've literally done this and shown to Oliver that I did it, and he said he doesn't care and gave me the same explanation that i'm giving to u rn. he's also announced on numerous occasions in the OS that he doesn't care when people do this

oliver-ni commented 3 years ago

It's not that I don't care about it. It's just not a huge priority for me as you're just paying the price sooner. Of course, if someone is using alts to exploit this issue, they'll be punished.

Kuraven commented 3 years ago

It's not that I don't care about it. It's just not a huge priority for me as you're just paying the price sooner. Of course, if someone is using alts to exploit this issue, they'll be punished.

ah alr then

yorii260 commented 3 years ago

It's not that I don't care about it. It's just not a huge priority for me as you're just paying the price sooner. Of course, if someone is using alts to exploit this issue, they'll be punished.

I can provide evidence of one who is abusing it, and it is on his main account.

Kuraven commented 3 years ago

It's not that I don't care about it. It's just not a huge priority for me as you're just paying the price sooner. Of course, if someone is using alts to exploit this issue, they'll be punished.

I can provide evidence of one who is abusing it, and it is on his main account.

If it's his main the why is it a reportable issue? The reason ppl are being punished is because they do it on alts and then throw away those alts. If u do it on ur main u're gonna have to pay the price by waiting a rly long time to open boxes again, meaning that u dont cheat the system by doing it on ur main.

cillosis commented 3 years ago

I vote to investigate this issue as it has been proposed multiple times. Unless there are future plans that negate this as a problem?

oliver-ni commented 3 years ago

I think putting a max_concurrency would pretty much solve this problem.

cillosis commented 3 years ago

Or just make it impossible to go negative. Any attempts (bad actors) means lost boxes and it is there own fault. This doesn't have to be complicated.

oliver-ni commented 3 years ago

https://github.com/poketwo/poketwo/blob/70568c325d65596a144393f2cc64bce8f00d279c/cogs/shop.py#L179-L190

Using find_one_and_update and putting {"gifts_ultra": {"$gte": amt}} in the query would work. Instead of separate fetch and update.

yorii260 commented 3 years ago

https://github.com/poketwo/poketwo/blob/70568c325d65596a144393f2cc64bce8f00d279c/cogs/shop.py#L179-L190

Using find_one_and_update and putting {"gifts_ultra": {"$gte": amt}} in the query would work. Instead of separate fetch and update.

😘