pokey / command-server

Secure VSCode communication channel designed for voice coding
MIT License
16 stars 9 forks source link

Commands time out when terminal is focused #14

Open sbungartz opened 2 years ago

sbungartz commented 2 years ago

Whenever the built in terminal of VS Code has focus, commands issued using user.vscode are no longer working. Instead you get a time out in talon log.

For example:

  1. Open a VS Code window and focus the built in terminal.
  2. Say please
  3. Nothing happens, except the following error showing up in talon log:
    talon.scripting.talon_script.TalonScriptError: 
    in script at /home/simon/.talon/user/knausj_talon/apps/vscode/vscode.talon:16:
    > user.vscode('workbench.action.showCommands')
    Exception: Timed out waiting for response

I am on

Maybe this is a Linux thing, but I have no idea why focusing the terminal would stop command server from reading files...

AndreasArvidsson commented 2 years ago

Weird. This appears to be working fine on windows.

sbungartz commented 2 years ago

I have found a way to make this work. After adding command-server.runCommand to the list of commands whose keybindings will always be handled by VS Code (terminal.integrated.commandsToSkipShell), it works!

image

Otherwise the key combination seems to be handled by the terminal.

Do you know if there is a way for this plugin to insert itself into this setting automatically?

pokey commented 2 years ago

Yes that's the one; couldn't remember the setting name. Glad you were able to find it

Yes I believe there is a way to do that. Settings can contribute default values, and if that doesn't work they can actually just modify settings directly

frosk1 commented 1 year ago

had the same issue and it could be resolved with adding "command-server.runCommand" to terminal.integrated.commandsToSkipShell like @sbungartz