codepathreview
commented
9 years ago hi @pokiebo here is my feedback in this week's assignment!
:+1: nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:
- For the restaurant cell, note that the subviews should be private.
- Great work on restaurant updates handled by the Swift property observer.
- Note that you should resolve all the Auto Layout constraint warnings in your nibs.
- It's acceptable to avoid dequeuing the cells, especially in small forms. However, it is still good practice to link the form with the underlying model. See this popular form library for an alternative to implementing forms manually.
- It would have been more elegant to use a custom filter delegate to respond to events of the switches being toggled. Less coupling between the cell and the FilterViewController.
This was a challenging assignment, congrats on completing it successfully!
-- dirk
@codepathreview