What is the purpose of the second Core::init overload? - Githubissues

pokitto / PokittoLib

Library for making programs on Pokitto hardware

22 stars 16 forks source link

What is the purpose of the second Core::init overload? #151

Open Pharap opened 3 years ago

Pharap commented 3 years ago

While trying to help Spinal solve his audio problems, I noticed there are two Core::init overloads implemented identically.

https://github.com/pokitto/PokittoLib/blob/697063cbf7d8ca7c80989f592c31e6a13b51c14a/Pokitto/POKITTO_CORE/PokittoCore.cpp#L756-L766 https://github.com/pokitto/PokittoLib/blob/697063cbf7d8ca7c80989f592c31e6a13b51c14a/Pokitto/POKITTO_CORE/PokittoCore.cpp#L768-L778

Are both of these necessary?

If so, the difference/purpose should be documented
If not, the superfluous one should be removed