search

pokitto / PokittoLib

Library for making programs on Pokitto hardware
22 stars 16 forks source link

wrong declaration of fileGetChar() #16

Closed dromer closed 6 years ago

dromer commented 6 years ago

Here this empty function is declared as an int, while in the header it's set as a char.

https://github.com/pokitto/PokittoLib/blob/08e28c657a0f1d74549d4bdeba717995a5e8765c/Pokitto/POKITTO_LIBS/FileIO/FileIO_HW.cpp#L68 https://github.com/pokitto/PokittoLib/blob/08e28c657a0f1d74549d4bdeba717995a5e8765c/Pokitto/POKITTO_LIBS/FileIO/FileIO.h#L19

Which is it? :)

pokitto commented 6 years ago

Need to check. Too busy atm.

Pharap commented 6 years ago

FileIO_SIM.cpp has a functioning implementation that returns char, so it's FileIO_HW.cpp that's at fault. (So that answers the "Which is it?" part at least.)

The implementation is empty so I'm guessing this is either a library that hasn't been implemented for hardware yet or isn't supposed to be implemented for hardware.