Adds the e2e test suite framework and a bit over 80 test scenarios

pokt-network / pocket-core

Official implementation of the Pocket Network Protocol

http://www.pokt.network

MIT License

209 stars 103 forks source link

Adds the e2e test suite framework and a bit over 80 test scenarios #1514

Closed iajrz closed 1 year ago

iajrz commented 1 year ago

This PR has both Go code and a cucumber test suite in gherkin; I'd expect @Olshansk to look at the go side of the matter and @emedrano2112 and @AneudyM to look at the gherkin side of the matter.

Fixes #1482

Co-authored-by: Daniel Olshansky olshansky@pokt.network

Olshansk commented 1 year ago

@iajrz I'll continue reviewing once the existing comments are resolved or Once the existing comments are resolved or tended

Olshansk commented 1 year ago

@iajrz I saw that you pushed some updates. Please re-request a review (see screenshot) when it's ready for another round

Screenshot 2022-12-20 at 3 50 38 PM

Olshansk commented 1 year ago

@iajrz I updated the documentation, added a few comments and refactored a bit of the code. I'm in favour of adopting a similar pattern (with a simpler initial implementation) in V1 using gherkin.

Lmk if you see issue with any of my changes. If not, I can go ahead and merge it in.

cc @jessicadaugherty for visibility