Placeholder for clearing session cache for unjailed vals with upgrade height

pokt-network / pocket-core

Official implementation of the Pocket Network Protocol

http://www.pokt.network

MIT License

209 stars 103 forks source link

Closed nodiesBlade closed 1 year ago

nodiesBlade commented 1 year ago

Disclaimer: Never done an upgrade height transaction before, please do a test in local net, testnet, and so on for this upgrade

Addresses concerns in #1529 by adding an upgrade height

Olshansk commented 1 year ago

@msmania PTAL when you have a chance as another pair of 👀

msmania commented 1 year ago

Sorry for being late, and thank you @PoktBlade for creating this. I totally agree with your comment https://github.com/pokt-network/pocket-core/issues/1529#issuecomment-1459082393. It's technically possible that the network reaches wrong consensus if the majority of validators end up having unupdated session cache.

This patch looks good to me.

Olshansk commented 1 year ago

@PoktBlade Okay to close this one out in favor of #1529 so we can finish it off there?

Olshansk commented 1 year ago

Closing it seeing how #1529 was merged in.