search

pokt-network / pocket-core

Official implementation of the Pocket Network Protocol
http://www.pokt.network
MIT License
209 stars 103 forks source link

Update tendermint version #1541

Closed Olshansk closed 1 year ago

Olshansk commented 1 year ago

Update the tendermint fork version.

Testing

Validated use LocalNet instructions at doc/guides/localnet.md

Changes

reviewpad[bot] commented 1 year ago

AI-Generated Pull Request Summary: This pull request updates the Tendermint version in the pokt-network/pocket-core project by modifying the go.mod and go.sum files. The Tendermint version is changed from v0.32.11-0.20220824215059-3214a152d8d4 to v0.32.11-0.20230405220629-96c095f0058d.

reviewpad[bot] commented 1 year ago

AI-Generated Summary: This pull request updates the tendermint version dependency in the go.mod file, changing it from v0.32.11-0.20220824215059-3214a152d8d4 to v0.32.11-0.20230405220629-96c095f0058d.

Olshansk commented 1 year ago

I can see your struggle on go.mod stuff in the tendermint's commit history :)

Haha, yea... Not a fun thing but not something we'll need to worry about in v1.

I'm actually going to hold of on merging this one in until @aqt01 launches a few nodes on TestNet to see how a heterogeneous (w.r.t to Tendermint) network behaves.

Screenshot 2023-04-07 at 10 56 56 AM

fredteumer commented 1 year ago

@Olshansk

is this going to be deployed on mainnet or testnet?

also do you want the node to be spun from no state/genesis or from an existing state?

Olshansk commented 1 year ago

@Olshansk is this going to be deployed on mainnet or testnet? also do you want the node to be spun from no state/genesis or from an existing state?

tl;dr I'm going to merge this into main and tag the commit as beta. We, as PNI, should deploy it on MainNet both from genesis and from the latest snapshot you have.

--- Extra optional details ---

@fredteumer This has already been deployed on both TestNet and MainNet per the updates in the Tendermint testing in the release guide.

@aqt01 and @StevenMartinez94 are maintaining it on TestNet

@msmania are deploying it on MainNet

The conversation is ongoing in the public discord channel here.

Olshansk commented 1 year ago

We've been tracking progress of this branch for several days on mainnet & testnet now so will merge this into main.

https://www.notion.so/pocketnetwork/Testing-Tendermint-fbcd3abbed5b4d1ea470a964e2e8b014?pvs=4