search

pokt-network / pocket-core

Official implementation of the Pocket Network Protocol
http://www.pokt.network
MIT License
208 stars 101 forks source link

Fix infinite recursion in Session.HashString #1579

Closed cristaloleg closed 8 months ago

cristaloleg commented 10 months ago

Description

Fixes #1578

Summary generated by Reviewpad on 06 Sep 23 07:14 UTC

This pull request fixes an issue with infinite recursion in the HashString method of the Session struct. The patch adds a fix to the method by returning s.SessionHeader.HashString() instead of calling s.HashString() recursively. Additionally, there are some code formatting changes and comments added for clarification.

reviewpad[bot] commented 10 months ago

Thank you @cristaloleg for this first contribution!

cristaloleg commented 8 months ago

Can someone retry the error, please?

msmania commented 7 months ago

@cristaloleg Did you find any error from this? You closed the PR without merge, but I think this was good to be merged.

Olshansk commented 7 months ago

@msmania Just cherry-pick this commit in a new PR, I'll approve and we'll get it in.