pokt-network / pocket-ios-sdk

An iOS SDK to connect to the Pocket Network
MIT License
6 stars 3 forks source link

Review: June 25, 2018 #19

Closed ArtSabintsev closed 6 years ago

ArtSabintsev commented 6 years ago

One problem I have is that your models nil coalesce ?? to empty strings, rather than throwing errors. I think that should be rectified.

Also, you need documentation everywhere.

Merge this in, and then we can restructure the project again. Once you begin integrating the SDK, we can fix the rest of the wholes. Without documentation, proper error handling, and an actual example implementation, it's hard to refactor this code properly.