Closed Olshansk closed 1 year ago
Note: I am currently working on this.
+1 Updated you as an owner in the description changed this to in progress
@DragonDmoney Do you think this is something you can have up for review by the end of the month?
Somewhat tackled in #154 by merging the two structures in protobuf. Will leave the rest to #163
Spoke to @DragonDmoney offline and he mentioned he won't be working on this any longer.
@Olshansk I would like to take a swing at this issue if its still relevant? I have working code that passes tests ready to submit a PR if its still applicable?
@Olshansk I would like to take a swing at this issue if its still relevant? I have working code that passes tests ready to submit a PR if its still applicable?
Still applicable, let's do it!
Objective
Remove redundant code used by the
Pool
andAccount
actors in the persistence module introduced in https://github.com/pokt-network/pocket/pull/73.This is a good starter task opportunity to get acquainted with the codebase in the persistence module.
Origin Document
From the utility specification, a
Pool
is described as:Similar to how the functionality of Fisherman, ServiceNode, Validator and Application was consolidated via
persistence/schema/protocol_actor.go
andpersistence/schema/base_actor.go
, the functionality of Pool and Account can also be shared to remove redundant code.Goals
Deliverables
Pool
andAccount
into a common interfacepersistence/schema/account.go
,persistence/account.go
,persistence/test/account_test.go
Testing Methodology
$ make test_persistence
$ make test_all
LocalNet
following the instructions indocs/development/README.md
Non-goals
Creator: @Olshansk Owner: @DragonDmoney Co-Owners: @andrewnguyen22