pokt-network / pocket

Official implementation of the Pocket Network Protocol v1
https://pokt.network
MIT License
64 stars 33 forks source link

[Tooling][Savepoints/Rollbacks] Implement RPC endpoints for Snapshots/Rollbacks (no-op / faked) #565

Open deblasis opened 1 year ago

deblasis commented 1 year ago

Objective

The RPC layer should allow the triggering of snapshot creation, rollbacks and also basic queries about the available snapshots (this can become useful later as we develop alternative sources for snapshots)

Note: This issue can be worked on in parallel by calling no-op/fake methods in the backend (handlers.go) for now. When the savepoints/rollbacks are fully implemented, we can wire things together with the real implementation in the follow-up ticket (#570)

Origin Document

493 and #562

Goals

Deliverable

Non-goals / Non-deliverables

General issue deliverables

Testing Methodology


Creator: @deblasis Co-Owners: @Olshansk

h5law commented 1 year ago

Is this ticket ready to be implemented? I am unsure what the metadata returned by /v1/persistence/snapshots/create would look like (in the OpenAPI YAML spec for example). I realise the logic in handlers.go can point to some placeholder functions but is there any defined structure for what should be returned and stored locally? Or is that also a part of this PR?

Olshansk commented 1 year ago

There's still a fair bit of work before this piece is ready. @deblasis or I will follow up once it is.