[P2P][Consensus] Separate consensus and P2P IDs - Githubissues

pokt-network / pocket

Official implementation of the Pocket Network Protocol v1

https://pokt.network

MIT License

63 stars 33 forks source link

[P2P][Consensus] Separate consensus and P2P IDs #748

Open jessicadaugherty opened 1 year ago

jessicadaugherty commented 1 year ago

Objective

Separate consensus and P2P IDs to maintain a clear separation of concerns between consensus and P2P layers and prevent unintended interference between different node identity types.

Origin Document

Goals

Maintain a clear separation of concerns between consensus and P2P layers
Prevent unintended interference between different node identity types
Ensure proper handling of consensus NodeId and P2P identity

Deliverable

[ ] Update the codebase to ensure consensus NodeId and P2P identity are kept separate
[ ] Implement necessary changes to prevent unintended interference between consensus and P2P layers
[ ] Update related documentation and code comments to reflect the separation of consensus NodeId and P2P identity

Non-goals / Non-deliverables

Refactoring of the codebase beyond the scope of separating consensus NodeId and P2P identity

General issue deliverables

[ ] Update the appropriate CHANGELOG
[ ] Update any relevant READMEs (local and/or global)
[ ] Update any relevant global documentation & references
[ ] If applicable, update the source code tree explanation
[ ] If applicable, add or update a state, sequence or flowchart diagram using mermaid

Testing Methodology

[ ] All tests: make test_all
[ ] LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @jessicadaugherty

Olshansk commented 1 year ago

@bryanchriswhite Let's review the comments in https://github.com/pokt-network/pocket-network-protocol/pull/33 and merge it in before tackling this one.