[Tooling] fix: changelog validation exits properly on failure

[bryanchriswhite]

Description

The changelog validation step wasn't testing the output for failure but instead was always exiting with status 0.

Summary generated by Reviewpad on 18 May 23 09:42 UTC

This pull request fixes a bug where changelog validation was not exiting properly on failure. The patch now correctly exits on failure.

Issue

N/A

Type of change

Please mark the relevant option(s):

• [ ] New feature, functionality or library
• [ ] Bug fix
• [ ] Code health or cleanup
• [ ] Major breaking change
• [ ] Documentation
• [x] Other: CI fix

List of changes

• CI validate step exits with appropriate status

Testing

• [ ] make develop_test; if any code changes were made
• [ ] make test_e2e on k8s LocalNet; if any code changes were made
• [ ] e2e-devnet-test passes tests on DevNet; if any code was changed
• [ ] Docker Compose LocalNet; if any major functionality was changed or introduced
• [ ] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
• [ ] I have tested my changes using the available tooling
• [ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

• [ ] I have updated the corresponding README(s); local and/or global
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
• [ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)