Secretbox keys

[h5law]

Description

This PR updates the V1 codebase to encrypt keys using NaCl (libsodium) SecretBox cipher instead of AES-GCM due to the large number of benefits. These include the ability to use a random nonce, excellent efficiency for small messages (our keys are small) and the XSalsa20 stream cipher used by SecretBox provides a higher confidence in its security compared to AES and is a faster safer implementation compared to AES.

This change means V0 keys are now only partially interoperable with V1 and can now only be imported via their private hex strings.

A tool to convert V0 JSON files to V1 JSON files: https://gist.github.com/h5law/b5fde79f629ba960886b98ac12de6536 at a later date this can be implemented into the web wallet or CLI.

Summary generated by Reviewpad on 14 Jun 23 13:31 UTC

This pull request contains various updates related to the Keybase module in the codebase. It includes changes to the implementation of private key encryption and armouring, child key generation, and interoperability between protocols. The TestKeybase_ImportKeyFromStringNoPassphrase test function has been updated and is passing, and the debug_keybase.bak file has changed in the build/debug_keybase directory. Additionally, CHANGELOG.md has been updated with new version releases 0.0.0.35, 0.0.0.49, and 0.0.0.61, with changes to encryption and backup binary. Finally, the shared/crypto/README.md file has been updated with documentation related to cryptographic operations in this package.

Issue

Fixes N/A

Type of change

Please mark the relevant option(s):

• [x] New feature, functionality or library
• [ ] Bug fix
• [ ] Code health or cleanup
• [ ] Major breaking change
• [x] Documentation
• [ ] Other

List of changes

• Update keys to use SecretBox instead of AES-GCM for their encryption
• Update relevant documentation

Testing

• [x] make develop_test; if any code changes were made
• [x] make test_e2e on k8s LocalNet; if any code changes were made
• [ ] e2e-devnet-test passes tests on DevNet; if any code was changed
• [x] Docker Compose LocalNet; if any major functionality was changed or introduced
• [x] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
• [x] I have tested my changes using the available tooling
• [ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

• [x] I have updated the corresponding README(s); local and/or global
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
• [ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

[h5law]

@Olshansk bump

[codecov[bot]]

Codecov Report

Patch and project coverage have no change.

Comparison is base (2489d3b) 31.52% compared to head (1a4293c) 31.52%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #780 +/- ## ======================================= Coverage 31.52% 31.52% ======================================= Files 107 107 Lines 9034 9034 ======================================= Hits 2848 2848 Misses 5846 5846 Partials 340 340 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.