pokt-network / pocket

Official implementation of the Pocket Network Protocol v1

https://pokt.network

MIT License

61 stars 33 forks source link

[Utility] Rename Fisherman to Watcher #785

Open Olshansk opened 1 year ago

Olshansk commented 1 year ago

Objective

Eliminate all instances & references to 🎣 in the codebase and specs.

Origin Document

701

Goals

Use self-explanatory naming conventions for one of the key components in the protocol
Reduce confusion / ambiguity for newcomers to the protocol
Make the codebase clearer to understand and reason about

Deliverable

[ ] Update and merge in the ADR pokt-network/pocket-network-protocol#38 (files)
[ ] Update the specification pokt-network/pocket-network-protocol
[ ] Update the codebase pokt-network/pocket
[ ] Use MidJourney or playgroundai.com to come out with a cool logo for the Watcher; may or may not be Game of Thrones related

Non-goals / Non-deliverables

Updating any related presentations or notion documents
Eliminating Fisherman from our git history
Pretending that the term Fisherman never existed

General issue deliverables

[ ] Update the appropriate CHANGELOG(s)
[ ] Update any relevant local/global README(s)
[ ] Update relevant source code tree explanations
[ ] Add or update any relevant or supporting mermaid diagrams

Testing Methodology

[ ] Task specific tests or benchmarks: make ...
[ ] New tests or benchmarks: make ...
[ ] All tests: make test_all
[ ] LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md
[ ] k8s LocalNet: verify a k8s LocalNet is still functioning correctly by following the instructions here

Creator: @Olshansk Co-Owners: @dylanlott