Summary generated by Reviewpad on 25 May 23 21:27 UTC
This pull request contains two patches. The first patch fixes an issue where the nonInteractive flag was not being checked when requesting passwords in a few places. The second patch updates the changelog to include the addition of the nonInteractive flag.
Issue
NA
Type of change
Please mark the relevant option(s):
[ ] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other
List of changes
Add the nonInteractive flag check where it was missing
Testing
[ ] make develop_test; if any code changes were made
[ ] make test_e2e on k8s LocalNet; if any code changes were made
[ ] e2e-devnet-test passes tests on DevNet; if any code was changed
Description
Summary generated by Reviewpad on 25 May 23 21:27 UTC
This pull request contains two patches. The first patch fixes an issue where the nonInteractive flag was not being checked when requesting passwords in a few places. The second patch updates the changelog to include the addition of the nonInteractive flag.
Issue
NA
Type of change
Please mark the relevant option(s):
List of changes
nonInteractive
flag check where it was missingTesting
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)