[P2P] Module-level background router peer discovery coverage - Githubissues

pokt-network / pocket

Official implementation of the Pocket Network Protocol v1

https://pokt.network

MIT License

61 stars 33 forks source link

[P2P] Module-level background router peer discovery coverage #793

Open bryanchriswhite opened 1 year ago

bryanchriswhite commented 1 year ago

Description

Adding module-level test coverage over the kademlia-backed peer discovery mechanism which the background router encapsulates.

Issue

Addresses most (if not all) deliverables in #712

Type of change

Please mark the relevant option(s):

[ ] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes

...

Testing

[ ] make develop_test; if any code changes were made
[ ] make test_e2e on k8s LocalNet; if any code changes were made
[ ] e2e-devnet-test passes tests on DevNet; if any code was changed
[ ] Docker Compose LocalNet; if any major functionality was changed or introduced
[ ] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
[ ] I have tested my changes using the available tooling
[ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (a8206ec) 29.79% compared to head (a00b9d1) 29.79%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feat/integrate-bg-router #793 +/- ## ========================================================= Coverage 29.79% 29.79% ========================================================= Files 108 108 Lines 8867 8867 ========================================================= Hits 2642 2642 Misses 5915 5915 Partials 310 310 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.