Closed okdas closed 1 year ago
Patch coverage has no change and project coverage change: -0.03
:warning:
Comparison is base (
fba11c3
) 30.18% compared to head (0d4860e
) 30.15%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@okdas Please update
@Olshansk done! Thank you for the reminder - this is not possible to do during a new issue creation, and occasionally, I forget to do that after the issue is created.
Description
Cluster manager was not aware of new binary p1.
Summary generated by Reviewpad on 01 Jun 23 19:43 UTC
This pull request contains 4 patches which make several changes in the project. The first patch changes the binary name for cluster manager. The second patch uses a custom-runner. The fourth patch attempts to fix an issue with installing argo. The fifth patch fixes a misspelling in one of the shell commands.
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)