pokt-network / pocket

Official implementation of the Pocket Network Protocol v1
https://pokt.network
MIT License
61 stars 33 forks source link

[ClusterManager] change client binary name in cluster manager #798

Closed okdas closed 1 year ago

okdas commented 1 year ago

Description

Cluster manager was not aware of new binary p1.

Summary generated by Reviewpad on 01 Jun 23 19:43 UTC

This pull request contains 4 patches which make several changes in the project. The first patch changes the binary name for cluster manager. The second patch uses a custom-runner. The fourth patch attempts to fix an issue with installing argo. The fifth patch fixes a misspelling in one of the shell commands.

Type of change

Please mark the relevant option(s):

List of changes

Testing

Required Checklist

If Applicable Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (fba11c3) 30.18% compared to head (0d4860e) 30.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #798 +/- ## ========================================== - Coverage 30.18% 30.15% -0.03% ========================================== Files 103 103 Lines 8694 8715 +21 ========================================== + Hits 2624 2628 +4 - Misses 5755 5771 +16 - Partials 315 316 +1 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/pokt-network/pocket/pull/798/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pokt-network)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Olshansk commented 1 year ago

@okdas Please update Screenshot 2023-06-01 at 3 45 15 PM

okdas commented 1 year ago

@Olshansk done! Thank you for the reminder - this is not possible to do during a new issue creation, and occasionally, I forget to do that after the issue is created.