pokt-network / pocket

Official implementation of the Pocket Network Protocol v1
https://pokt.network
MIT License
61 stars 33 forks source link

[Persistence] Add Logger to TreeStore #809

Closed dylanlott closed 1 year ago

dylanlott commented 1 year ago

Description

Adds logs to the TreeStore module.

Issue

Adds some polish to #756

Type of change

Please mark the relevant option(s):

List of changes

Testing

Required Checklist

If Applicable Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -3.58 :warning:

Comparison is base (ccd7d41) 30.80% compared to head (b0e7900) 27.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## tree-store-module #809 +/- ## ===================================================== - Coverage 30.80% 27.22% -3.58% ===================================================== Files 109 76 -33 Lines 9246 4808 -4438 ===================================================== - Hits 2848 1309 -1539 + Misses 6058 3365 -2693 + Partials 340 134 -206 ``` [see 33 files with indirect coverage changes](https://app.codecov.io/gh/pokt-network/pocket/pull/809/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pokt-network)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Olshansk commented 1 year ago

@dylanlott is this waiting for a review?

dylanlott commented 1 year ago

@dylanlott is this waiting for a review?

Yes but it's lower priority, just adds a logger for the TreeModule and some process logs. 🪵

gitguardian[bot] commented 1 year ago

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!