Closed h5law closed 1 year ago
Patch coverage: 77.08
% and project coverage change: +0.33
:tada:
Comparison is base (
2d4f789
) 31.52% compared to head (9198c7a
) 31.86%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
NOTE @Olshansk, @dylanlott is currently working on savepoints/rollbacks that touches the same code and this PR will probably only be used as a reference as he is changing the logic their. The new wrapper functions fix the bug with Delete()
but need to be integrated with savepoints. Will wait on merging this until @dylanlott gives an update
This PR is already complete and ready to be merged in, while savepoints & rollbacks PR is 1+ weeks away.
IMO we should merge this in and iterate on top of it. However, I will defer to @dylanlott to decide.
This PR is already complete and ready to be merged in, while savepoints & rollbacks PR is 1+ weeks away.
IMO we should merge this in and iterate on top of it. However, I will defer to @dylanlott to decide.
I agree with merging this and addressing the logic changes necessary for savepoints later. It shouldn't hold this up.
Description
This PR introduces unit tests to cover the KVStore's functionality as well as updating the KVStore logic to use the Badger wrapper functions
update
,view
, etc.This fixes the issues around deleting keys from the KVStore.
Issue
Fixes N/A
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)