Closed okdas closed 12 months ago
@bryanchriswhite can you please check if functions/vars with //nolint:unused
are needed or can be deleted? Linter has been complaining that this code is not in use.
@okdas have you been running the linter via the make target and/or using --build-tags test
? All of those except the nonceDeduper
field are definitely used in tests. The `nonceDeduper should be cleaned up in #855 (check about halfway though the commits.
@bryanchriswhite I have not – these issues were reported by the CI. Thank you! I'll check how we can include the build tags for linter in GitHub Actions.
I thought I had updated it already in both the makefile and CI but maybe I missed something.
This ticket has been superseded by #885.
Description
Resolves current errors on
main
related togolangci-lint
linters checks not passing.Summary generated by Reviewpad on 21 Jun 23 22:00 UTC
This pull request fixes current golangci-lint errors. It touches three files, making a total of 17 insertions and 2 deletions. The changes include the removal of a duplicated import statement, the commenting of an unused code element, and the modification of a variable's data type in one function within a Go package. There are also some unused code elements and mocks included in the patch.
Type of change
Please mark the relevant option(s):
List of changes
Resolves the following issues reported by
golangci-lint
: