[Persistence] Adds atomic Update for TreeStore

[dylanlott]

Description

Adds atomic savepoint and rollback creation to the TreeStore

Issue

Relates to #562

Type of change

Please mark the relevant option(s):

• [x] New feature, functionality or library
• [ ] Bug fix
• [ ] Code health or cleanup
• [ ] Major breaking change
• [ ] Documentation
• [ ] Other

List of changes

• adds savepoints and rollbacks to TreeStore Update function

Testing

• [x] make develop_test; if any code changes were made
• [x] make test_e2e on k8s LocalNet; if any code changes were made
• [x] e2e-devnet-test passes tests on DevNet; if any code was changed
• [ ] Docker Compose LocalNet; if any major functionality was changed or introduced
• [ ] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
• [ ] I have tested my changes using the available tooling
• [ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

• [ ] I have updated the corresponding README(s); local and/or global
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
• [ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

[dylanlott]

First off, amazing work 🚀 I love it <3

To clarify: this PR does not contain the rollbacks? Only the savepoints?

This PR implements the rollback functionality for block application in utility/unit_of_work/module.go.

Left a few comments my only major one is around the save function, I think we should do the importing during the load method as this will be ran less frequently 🤞🏼

I'm going to politely push back on this for now, with the caveat that I added an OPTIMIZE comment, but I do think this is a premature optimization with unclear benefits when weighed against the added Rollback function complexity. This should likely be examined in an ADR that more clearly discusses the trade-offs.

[Olshansk]

@dylanlott Please add me as a reviewer if/when you need additional feedback on this.

[h5law]

I'm going to politely push back on this for now, with the caveat that I added an OPTIMIZE comment, but I do think this is a premature optimization with unclear benefits when weighed against the added Rollback function complexity. This should likely be examined in an ADR that more clearly discusses the trade-offs.

I see your point, I missed the Rollback function in Trees, I got confused between it and the load world state function you had previously discussed with me offline. I think you are right that at a later date we can look into where the imports should go. I will rereview now and approve these as appart from that everything else was addressed 👍🏼