[WIP][IBC] Make the IBC Host a submodule with access to the bus

[h5law]

Description

Summary generated by Reviewpad on 30 Jun 23 15:11 UTC

This pull request includes multiple file diffs with various changes. Some of the changes include renaming types, modifying function calls, adding new methods, updating import statements, and making changes to the file structure and package names.

Here is a summary of the changes:

• In the file persistence/local/module.go, the type IntegratableModule has been renamed to IntegrableModule, and the function modules.ModuleOption has been replaced with modules.InjectableModule.
• In the file persistence_module.go, new methods SetIBCStoreEntry, RecordRelayService, and GetIBCStoreEntry have been added to the PersistenceWriteContext and PersistenceReadContext interfaces.
• In the file transport_encryption_test.go, import statements have been added, function names have been modified, and code lines have been updated.
• In the file router.go, import statements have been removed, types have been renamed, methods have been modified or added, and code lines have been updated.
• In the file provider.go, import statements have been added, the type persistencePeerstoreProvider has been modified, and a new line bus.RegisterModule(persistencePSP) has been added.
• Other files have similar changes and modifications, such as import statements, type renaming, method additions, and code updates.

Please review the full diff for more details.

Issue

Fixes #854

Type of change

Please mark the relevant option(s):

• [x] New feature, functionality or library
• [ ] Bug fix
• [ ] Code health or cleanup
• [ ] Major breaking change
• [ ] Documentation
• [ ] Other

List of changes

• Move IBC host into its own submodule
• Enable local ProvableStore instances to emit events to alter the IBC state tree

Testing

• [x] make develop_test; if any code changes were made
• [ ] make test_e2e on k8s LocalNet; if any code changes were made
• [ ] e2e-devnet-test passes tests on DevNet; if any code was changed
• [ ] Docker Compose LocalNet; if any major functionality was changed or introduced
• [ ] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
• [x] I have tested my changes using the available tooling
• [ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

• [ ] I have updated the corresponding README(s); local and/or global
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
• [ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

[h5law]

🚨 NOTE This PR includes the submodule PR #855 as well as the necissary changes to expose the TreeStore from the bus, and register Submodule types to the bus. This is included in the first commit.

[Olshansk]

🚨 NOTE This PR includes the submodule PR #855 as well as the necissary changes to expose the TreeStore from the bus, and register Submodule types to the bus. This is included in the first commit.

@h5law I've been trying not to enforce this in the past so we can move fast, but wanted to see if there's an opportunity to split this into smaller PRs?

For eg. changes to expose the TreeStore from the bus could be a small quick and easy to merge PR.

GOing to review this one as is (so please don't split it now), but keep this in mind for the future - it makes it easier for the reviewer.

---

EDIT: Realized that even though includes the submodule PR https://github.com/pokt-network/pocket/pull/855 as, it's not a base PR for this one, so I'll wait for either:

• Updating the based branch for this
• Having the other PR be merge din

[h5law]

@Olshansk

@h5law I've been trying not to enforce this in the past so we can move fast, but wanted to see if there's an opportunity to split this into smaller PRs?

For eg. changes to expose the TreeStore from the bus could be a small quick and easy to merge PR.

So @dylanlott is including these changes in his rollbacks PR, they were a part of a smaller PR but have been moved