Closed Olshansk closed 11 months ago
If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
@dylanlott @red-0ne @adshmh Please note that this test is still a bit flaky for now (will solidify it next week), but I think this change is close enough to start getting reviews on.
@red-0ne Could you please prioritize taking a look at this?
@0xBigBoss I've created #959 and added TODO comments so we can either poll on heights on healthchecks in a followup commit. Also, to avoid PRs that are too large, would appreciate if you could split out things that are possible.
For example, this used to be part of the state sync PR, but I split it out to make it easier for the reviewer instead of having one multi-thousand line PR.
Description
Summary generated by Reviewpad on 03 Aug 23 20:11 UTC
This pull request introduces several changes across multiple files.
Here is a summary of the changes:
go.mod
:golang.org/x/text
dependency is now listed explicitly instead of being an indirect dependency.scenario_test.go
:FAQ.md
:make compose_and_watch
withmake lightweight_localnet
to avoid permission denied errors..gitignore
:e2e/README.md
:Keywords
.Consensus module files:
HandleDebugMessage
function.DEBUG_CONSENSUS_RESET_TO_GENESIS
action..tiltignore
:CHANGELOG.md
:Keywords
.persistence/docs/CHANGELOG.md
:validator.feature
:tilt_helpers.go
:debug.go
:account.feature
:README.md
files:build/config/README.md
:make compose_and_watch
tomake lightweight_localnet
.iteration_3_end_to_end_tx.md
:Deleted files:
validator.go
watch_build.sh
New files added:
debug.feature
tilt_helpers.go
account.feature
Please let me know if you need more information about any specific change.
Issue
Fixes par of #579
Type of change
Please mark the relevant option(s):
List of changes
s/compose_and_watch/lightweight_localnet
and all related helperss/validator/node
in e2e tests for clarityDebug
CLI w/ several useful initial subcommandskeywords
to thee2e
documente2e debug
test to trigger views and track the blockchain increasingTesting
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)