pokt-network / pocket

Official implementation of the Pocket Network Protocol v1
https://pokt.network
MIT License
63 stars 33 forks source link

[CLI] Consistent config/flag parsing & common helpers #891

Closed bryanchriswhite closed 1 year ago

bryanchriswhite commented 1 year ago

@Reviewer

This PR may be more digestible / reviewable on a commit-by-commit basis. Commits are organized logically and any given line is only modified in a single commit, with few exceptions*.

(In the interest of preserving the git-time-continuum :police_officer::rotating_light:, this applies in batches of commits between comments or reviews by humans*, only once "in review")


Description

I discovered some inconsistencies in how/whether we parse the config in different subcommands.

There was also some code that turns out to be common between some existing commands and the ones I'm adding for #730.

Issue

Related:

Dependents:

Type of change

Please mark the relevant option(s):

List of changes

Testing

Required Checklist

If Applicable Checklist