Closed dylanlott closed 2 months ago
@dylanlott Can you "re-request" a review when its ready and I'll reply to all the comments/questions then?
@dylanlott Can you "re-request" a review when its ready and I'll reply to all the comments/questions then?
You beat me to it. I just finished up addressing your feedback, it's ready for re-review 👍
Description
Adds save and load functionality to the TreeStore.
This PR makes the
TreeStore
anInterruptable
module. This is necessary because the Persistence module needs to be able to tell theTreeStore
to relinquish its connection to thenodeStores
which are backed by BadgerDB.Issue
Related to #568
Type of change
Please mark the relevant option(s):
List of changes
worldState
from file directories.Testing
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)