Summary generated by Reviewpad on 14 Jul 23 23:17 UTC
This pull request includes a series of patches that make changes to the file debug.go in the shared/k8s directory.
Patch 1/5: The patch retrieves keys for all actors from k8s secrets. It adds support for retrieving private keys for validators, servicers, fisherman, and applications.
Patch 2/5: This patch fixes a linter error in the fetchPrivateKeys function by updating the function signature to use a single string parameter for resourceName and actor.
Patch 3/5: This patch further fixes linter errors in the same function and shortens the code by removing unnecessary switch cases.
Patch 4/5: This patch updates the constant for the secret resource name from privateKeysSecretResourceNameFisherman to privateKeysSecretResourceNameFishermen.
Patch 5/5: This patch fixes a typo in the function name FetchFishermanPrivateKeys by updating the privateKeysSecretResourceName to privateKeysSecretResourceNameFishermen.
Please review these changes and ensure they are appropriate.
Issue
Added as a TODO in #869:
Type of change
Please mark the relevant option(s):
[ ] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other
List of changes
Fetch keys for all actors from k8s instead of just validators so they can be used in our debug libraries
Testing
[x] make develop_test; if any code changes were made
[x] make test_e2e on k8s LocalNet; if any code changes were made
[ ] e2e-devnet-test passes tests on DevNet; if any code was changed
Description
Summary generated by Reviewpad on 14 Jul 23 23:17 UTC
This pull request includes a series of patches that make changes to the file
debug.go
in theshared/k8s
directory.Patch 1/5: The patch retrieves keys for all actors from k8s secrets. It adds support for retrieving private keys for validators, servicers, fisherman, and applications.
Patch 2/5: This patch fixes a linter error in the
fetchPrivateKeys
function by updating the function signature to use a single string parameter forresourceName
andactor
.Patch 3/5: This patch further fixes linter errors in the same function and shortens the code by removing unnecessary switch cases.
Patch 4/5: This patch updates the constant for the secret resource name from
privateKeysSecretResourceNameFisherman
toprivateKeysSecretResourceNameFishermen
.Patch 5/5: This patch fixes a typo in the function name
FetchFishermanPrivateKeys
by updating the privateKeysSecretResourceName toprivateKeysSecretResourceNameFishermen
.Please review these changes and ensure they are appropriate.
Issue
Added as a TODO in #869:
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)