Summary generated by Reviewpad on 21 Jul 23 19:52 UTC
This pull request includes several file diffs with various changes. Here is a summary of the changes:
The file persistence/types/ibc.go has changes to the functions InsertIBCStoreEntryQuery, InsertIBCEventQuery, and GetIBCStoreEntryQuery, modifying the data type of the height parameter from int64 to uint64.
The file runtime/bus.go has a new method GetClientManager() added to the bus struct, which retrieves a modules.ClientManager module from the registry.
The file bulk_store_cache.go has a change in the AddStore function, where the code store := newProvableStore(s.GetBus(), coreTypes.CommitmentPrefix(name), s.privateKey) has been changed to store := NewProvableStore(s.GetBus(), coreTypes.CommitmentPrefix(name), s.privateKey).
The diff in the file ibc_test.go in the persistence/test directory includes several changes related to the height parameter type, function renames, and removal of event.Height assignments and assertions.
A new file introspect.go has been added to the ibc/client package, introducing functions related to managing the client state for the Pocket network in the context of the IBC protocol.
The file ibc/main_test.go has a change in the newTestP2PModule function, where the line bus.RegisterModule(p2pMock) has been removed.
A new file queries.go has been added to the ibc/client directory, containing functions GetConsensusState and GetClientState related to managing client information.
The file gov.go in the persistence package has changes to the GetRevisionNumber function, including a parameter type change and addition of TODO comments for the implementation of GetRevisionNumber and GetSupportedChains.
A new file ics02.md has been added to the ibc/docs directory, providing documentation for ICS-02, the client semantics in the IBC protocol.
The file ibc/host/submodule.go has changes related to the creation of an IBC host submodule and the initialization of its dependencies.
The file event_manager.go has changes to import statements, method signatures, and a new read context creation using the current height in the QueryEvents method.
A new file host_introspection_test.go has been added to the ibc package, containing test functions for obtaining the current height and host consensus state using the ClientManager.
The file client_state_paths.go has changes related to function names, parameter types, and addition of new functions.
The file README.md has been modified, adding a new section and updating the table of contents.
The file client_module.go contains the implementation of functions related to emitting events in the IBC client module.
The file persistence/types/ibc.go has changes to the function name and parameter types, as well as a new line of code that trims a string.
A new file submodule.go has been added to the ibc/client package, implementing a client manager module for the IBC protocol.
Please review these changes in the diff to ensure they align with the intended modifications.
Issue
Fixes #
Type of change
Please mark the relevant option(s):
[ ] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other
List of changes
Change #1
Change #2
...
Testing
[ ] make develop_test; if any code changes were made
[ ] make test_e2e on k8s LocalNet; if any code changes were made
[ ] e2e-devnet-test passes tests on DevNet; if any code was changed
Description
Summary generated by Reviewpad on 21 Jul 23 19:52 UTC
This pull request includes several file diffs with various changes. Here is a summary of the changes:
persistence/types/ibc.gohas changes to the functionsInsertIBCStoreEntryQuery,InsertIBCEventQuery, andGetIBCStoreEntryQuery, modifying the data type of theheightparameter fromint64touint64.runtime/bus.gohas a new methodGetClientManager()added to thebusstruct, which retrieves amodules.ClientManagermodule from the registry.bulk_store_cache.gohas a change in theAddStorefunction, where the codestore := newProvableStore(s.GetBus(), coreTypes.CommitmentPrefix(name), s.privateKey)has been changed tostore := NewProvableStore(s.GetBus(), coreTypes.CommitmentPrefix(name), s.privateKey).ibc_test.goin thepersistence/testdirectory includes several changes related to theheightparameter type, function renames, and removal ofevent.Heightassignments and assertions.introspect.gohas been added to theibc/clientpackage, introducing functions related to managing the client state for the Pocket network in the context of the IBC protocol.ibc/main_test.gohas a change in thenewTestP2PModulefunction, where the linebus.RegisterModule(p2pMock)has been removed.queries.gohas been added to theibc/clientdirectory, containing functionsGetConsensusStateandGetClientStaterelated to managing client information.gov.goin thepersistencepackage has changes to theGetRevisionNumberfunction, including a parameter type change and addition of TODO comments for the implementation ofGetRevisionNumberandGetSupportedChains.ics02.mdhas been added to theibc/docsdirectory, providing documentation for ICS-02, the client semantics in the IBC protocol.ibc/host/submodule.gohas changes related to the creation of an IBC host submodule and the initialization of its dependencies.event_manager.gohas changes to import statements, method signatures, and a new read context creation using the current height in theQueryEventsmethod.host_introspection_test.gohas been added to theibcpackage, containing test functions for obtaining the current height and host consensus state using the ClientManager.client_state_paths.gohas changes related to function names, parameter types, and addition of new functions.README.mdhas been modified, adding a new section and updating the table of contents.client_module.gocontains the implementation of functions related to emitting events in the IBC client module.persistence/types/ibc.gohas changes to the function name and parameter types, as well as a new line of code that trims a string.submodule.gohas been added to theibc/clientpackage, implementing a client manager module for the IBC protocol.Please review these changes in the diff to ensure they align with the intended modifications.
Issue
Fixes #
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)