Summary generated by Reviewpad on 26 Jul 23 09:37 UTC
This pull request includes the following changes:
Makefile:
Added lines to generate go structures for the ibc/client/types/proto/*.proto and ibc/client/light_clients/types/proto/*.proto files using the PROTOC_SHARED command.
ibc_host_module.go:
Removed the IBCHandler interface.
Updated the IBCHostSubmodule interface to only extend the Submodule and ibcHostFactory interfaces.
Removed the ibc_host constant.
Modified the return type of the GetTimestamp method.
Modified the return type of the GetProvableStore method.
Removed various IBC-related methods.
New file: pocket.proto:
Added a new proto file called "pocket.proto" in the "ibc/client/light_clients/types/proto" directory.
Defined multiple message types related to the Pocket network's IBC client.
bus_module.go:
Added a new method, "GetClientManager()", to the "Bus" interface.
New file: wasm.proto:
Added a new proto file called "wasm.proto" in the "ibc/client/types/proto" directory.
Defined several message types related to client and consensus states.
ibc_client_module.go:
Added a new Go package named "modules".
Defined constants, types, and interfaces for managing IBC light clients.
Included methods for client lifecycle management, client queries, and client state verification.
These changes cover updates to Makefile, interface definitions, addition of new files, and modifications to existing files.
Issue
Fixes #894
Type of change
Please mark the relevant option(s):
[x] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other
List of changes
Create the Client submodule interface
Add the ClientManager interface
Add the different interfaces for client types
Add proto definitions for WASM client generic types and Pocket specific definitons
Testing
[x] make develop_test; if any code changes were made
[x] make test_e2e on k8s LocalNet; if any code changes were made
[x] e2e-devnet-test passes tests on DevNet; if any code was changed
Description
Summary generated by Reviewpad on 26 Jul 23 09:37 UTC
This pull request includes the following changes:
Makefile:
ibc/client/types/proto/*.proto
andibc/client/light_clients/types/proto/*.proto
files using thePROTOC_SHARED
command.ibc_host_module.go:
IBCHandler
interface.IBCHostSubmodule
interface to only extend theSubmodule
andibcHostFactory
interfaces.ibc_host
constant.GetTimestamp
method.GetProvableStore
method.New file: pocket.proto:
bus_module.go:
New file: wasm.proto:
ibc_client_module.go:
These changes cover updates to Makefile, interface definitions, addition of new files, and modifications to existing files.
Issue
Fixes #894
Type of change
Please mark the relevant option(s):
List of changes
ClientManager
interfaceWASM
client generic types andPocket
specific definitonsTesting
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)