[Core] The Watch Begins - Githubissues

pokt-network / pocket

Official implementation of the Pocket Network Protocol v1

https://pokt.network

MIT License

61 stars 33 forks source link

[Core] The Watch Begins #956

Open Olshansk opened 11 months ago

Olshansk commented 11 months ago

Objective

Rename the Fisherman to the Watcher.

Origin Document

https://github.com/pokt-network/pocket/discussions/701#discussioncomment-6598863

Goals

Make protocol actor naming self-explanatory
Replace all instances of the fisherman to the watcher so responsibilities are clear

Deliverable

[ ] Rename all instances of Fishermen to Watchers in https://github.com/pokt-network/pocket
[ ] Rename all instances of Fishermen to Watchers in https://github.com/pokt-network/pocket-network-protocol
[ ] #973
[x] Be careful with casing (e.g. Fisherman vs fisherman as it relates to Watcher vs watcher) and plurality (e.g. fisherman vs fishermen as it relates to watcher vs watchers)

Non-goals / Non-deliverables

Any business logic changes
Updating all threads & conversations related to this
Updating notion docs

General issue deliverables

[ ] Update the appropriate CHANGELOG(s)
[ ] Update any relevant local/global README(s)
[ ] Update relevant source code tree explanations
[ ] Add or update any relevant or supporting mermaid diagrams

Testing Methodology

[ ] Task specific tests or benchmarks: make ...
[ ] New tests or benchmarks: make ...
[ ] All tests: make test_all
[ ] LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md
[ ] k8s LocalNet: verify a k8s LocalNet is still functioning correctly by following the instructions here

Creator: @Olshansk Co-Owners: @dylanlott @0xRampey

0xRampey commented 10 months ago

The renaming will be done in 3 PRs across the 3 repos stated in the deliverables above.