However, the diff above results in the following error whose root case we have failed to identify:
Goals
Improve the query claim tests
Reduce the turnaround time on running these tests
Deliverables
[ ] A PR that moves require.NoError(t, net.WaitForNextBlock()) outside of the forloop (as seen in the diff above) and guarantees the tests are still succeeding
Non-goals / Non-deliverables
Increasing test coverage
General deliverables
[ ] Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
[ ] Testing: Add new tests (unit and/or E2E) to the test suite.
[ ] Makefile: Add new targets to the Makefile to make the new functionality easier to use.
[ ] Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.
Objective
Reduce the feedback loop time of the unit tests in
query_claim_test.go
.Origin Document
Inside of
query_claim_test.go
, we wait for the next block every time a new claim is committed, which takes time, like so:Ideally, we would send all the
createClaim
transitions at once and wait for the next block to commit.However, the diff above results in the following error whose root case we have failed to identify:![Screenshot 2023-11-16 at 1 23 55 PM](https://github.com/pokt-network/poktroll/assets/1892194/0d30cb08-2a92-489c-b2c5-ee55295aa45d)
Goals
Deliverables
require.NoError(t, net.WaitForNextBlock())
outside of the forloop (as seen in the diff above) and guarantees the tests are still succeedingNon-goals / Non-deliverables
General deliverables
Creator: @Olshansk Co-Owners: ???