[Test] Improve the speed of unit tests in `query_claim_test`

[Olshansk]

Objective

Reduce the feedback loop time of the unit tests in query_claim_test.go.

Origin Document

Inside of query_claim_test.go, we wait for the next block every time a new claim is committed, which takes time, like so:

    sessionEndHeight := int64(1)
    for sessionNum := 0; sessionNum < numSessions; sessionNum++ {
        sessionEndHeight += numBlocksPerSession
        sessionId := fmt.Sprintf("session_id%d", sessionNum)
        for claimNum := 0; claimNum < numClaimsPerSession; claimNum++ {
            supplierAddr := addresses[claimNum]
            claim := createClaim(t, net, ctx, supplierAddr, sessionId, sessionEndHeight)
            claims = append(claims, *claim)
            require.NoError(t, net.WaitForNextBlock())
        }
    }

Ideally, we would send all the createClaim transitions at once and wait for the next block to commit.

diff --git a/x/supplier/client/cli/query_claim_test.go b/x/supplier/client/cli/query_claim_test.go
index 99702df..36b47d8 100644
--- a/x/supplier/client/cli/query_claim_test.go
+++ b/x/supplier/client/cli/query_claim_test.go
@@ -53,8 +53,6 @@ func createClaim(
    supplierAddr string,
    sessionId string,
    sessionEndHeight int64,
+   signerAccountNumber int,
+   signatureSequencerNumber int,
 ) *types.Claim {
    t.Helper()

@@ -65,12 +63,6 @@ func createClaim(
    args := []string{
        sessionHeaderEncoded,
        rootHashEncoded,
+
+       fmt.Sprintf("--%s=true", flags.FlagOffline),
+       fmt.Sprintf("--%s=%d", flags.FlagAccountNumber, signerAccountNumber),
+       fmt.Sprintf("--%s=%d", flags.FlagSequence, signatureSequencerNumber),

        fmt.Sprintf("--%s=%s", flags.FlagFrom, supplierAddr),
        fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
        fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastSync),
@@ -133,15 +125,13 @@ func networkWithClaimObjects(
    for sessionNum := 0; sessionNum < numSessions; sessionNum++ {
        sessionEndHeight += numBlocksPerSession
        sessionId := fmt.Sprintf("session_id%d", sessionNum)
+       signatureSequenceNumber := sessionNum
        for claimNum := 0; claimNum < numClaimsPerSession; claimNum++ {
            supplierAddr := addresses[claimNum]
+           signerAccountNumber := claimNum
+           claim := createClaim(t, net, ctx, supplierAddr, sessionId, sessionEndHeight, signerAccountNumber, signatureSequenceNumber)
-           claim := createClaim(t, net, ctx, supplierAddr, sessionId, sessionEndHeight)
            claims = append(claims, *claim)
-           require.NoError(t, net.WaitForNextBlock())
        }
    }
+   require.NoError(t, net.WaitForNextBlock())

    return net, claims
 }

However, the diff above results in the following error whose root case we have failed to identify:

Goals

• Improve the query claim tests
• Reduce the turnaround time on running these tests

Deliverables

• [ ] A PR that moves require.NoError(t, net.WaitForNextBlock()) outside of the forloop (as seen in the diff above) and guarantees the tests are still succeeding

Non-goals / Non-deliverables

• Increasing test coverage

General deliverables

• [ ] Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
• [ ] Testing: Add new tests (unit and/or E2E) to the test suite.
• [ ] Makefile: Add new targets to the Makefile to make the new functionality easier to use.
• [ ] Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

---

Creator: @Olshansk Co-Owners: ???

[Olshansk]

Not a priority and tracked in TODOs.