[☂️ Bug] Memory leaks: relay stress test

[bryanchriswhite]

f## Objective

Enumerate unique causes of memory leaks evident in the relay stress test scenario. This issue to be closed when all leaks tracked by it are resolved.

Origin Document

• RelayMiner go routine leak

Supporting documentation:

• Debugging > Memory Leaks (notion)

Goals

• Distinguishing & tracking known memory leaks.
• Facilitating the creation of issues for unique memory leaks.

Deliverables

• Accumulate known memory leaks in this issue's description

Non-goals / Non-deliverables

• Intentionally fixing listed memory leaks

General deliverables

• [ ] Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
• [ ] Testing: Add new tests (unit and/or E2E) to the test suite.
• [ ] Makefile: Add new targets to the Makefile to make the new functionality easier to use.
• [ ] Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

---

Creator: @bryanchriswhite Co-Owners: @red-0ne

[okdas]

1. 450 added some reader closures that might have been a part of the problem, I can check if the situation changed at all on main branch with this change.

2. I think the best way to troubleshoot it is to expose pprof on a separate port (configurable via the config file): https://pkg.go.dev/net/http/pprof - I can pick it up next week

[Olshansk]

I think the best way to troubleshoot it is to expose pprof on a separate port (configurable via the config file): pkg.go.dev/net/http/pprof - I can pick it up next week

Please add a TODO in the appropriate place (or create an issue if you think it needs one) depending on how long git'll take.

[bryanchriswhite]

Closing as memory leaks seem to have subsided (for now) as a result of continued work in load testing and complete integration. :muscle:

Re-purposing to include go routine leaks.

[Olshansk]

~Closing as memory leaks seem to have subsided (for now) as a result of continued work in load testing and complete integration.~ 💪

Re-purposing to include go routine leaks.

@bryanchriswhite Sgtm, but for future go-leaks, please create new tickets. I anticipate this won't be the last one.

Also, smaller PRs.