[Metrics] Additional off-chain metrics - Githubissues

pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev

MIT License

15 stars 7 forks source link

[Metrics] Additional off-chain metrics #468

Closed red-0ne closed 2 months ago

red-0ne commented 2 months ago

Summary

Update AppgateServer relay metrics and move metrics names to constants:

relaysSuccessTotal counter
relaysErrorTotal counter

Remove RelayMiner proxyName metric label and add the following:

relaysSuccessTotal counter
relayResponseSizeBytes histogram
relayRequestSizeBytes histogram

Issue

20
25

Type of change

Select one or more:

[x] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

[x] Unit Tests: make go_develop_and_test
[x] LocalNet E2E Tests: make test_e2e
[ ] DevNet E2E Tests: Add the devnet-test-e2e label to the PR. THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
[ ] Documentation changes: make docusaurus_start

Sanity Checklist

[x] I have tested my changes using the available tooling
[x] I have commented my code
[x] I have performed a self-review of my own code; both comments & source code
[x] I create and referenced any new tickets, if applicable
[x] I have left TODOs throughout the codebase, if applicable

github-actions[bot] commented 2 months ago

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.