[Config] feat: Simplify relay miner config - Githubissues

pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using the Cosmos SDK

MIT License

15 stars 8 forks source link

[Config] feat: Simplify relay miner config #477

Closed red-0ne closed 5 months ago

red-0ne commented 5 months ago

Summary

Simplify the relay miner config by removing the proxy section:

Rewrites the relay_miner_configs_reader.
Keeps the same resulting struct that's handled by the RelayMiner.
Update config reader tests and remove the no-longer applicable tests.
Update proxy tests.
Update the documentation to reflect the new config structure.
Update the RelayRequest server handler to support multiple services within the same host.

Issue

459

Type of change

Select one or more:

[ ] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[x] Documentation
[ ] Other (specify)

Testing

[x] Unit Tests: make go_develop_and_test
[x] LocalNet E2E Tests: make test_e2e
[ ] DevNet E2E Tests: Add the devnet-test-e2e label to the PR. THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
[ ] Documentation changes: make docusaurus_start

Sanity Checklist

[x] I have tested my changes using the available tooling
[x] I have commented my code
[x] I have performed a self-review of my own code; both comments & source code
[ ] I create and referenced any new tickets, if applicable
[ ] I have left TODOs throughout the codebase, if applicable

github-actions[bot] commented 5 months ago

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.